[Backtracing][Linux] Replace regex with ProcMapsScanner.#66449
[Backtracing][Linux] Replace regex with ProcMapsScanner.#66449al45tair merged 1 commit intoswiftlang:mainfrom
Conversation
|
@swift-ci Please smoke test |
mikeash
left a comment
mikeash
left a comment
There was a problem hiding this comment.
This is an excellent example of the power of regex.
There was a problem hiding this comment.
Using UInt8(ascii:) here would save people from looking up what ASCII 9 is, and be more consistent with the rest.
There was a problem hiding this comment.
:-) I'm probably showing my age there; I'll change to using UInt8(ascii:) for all of them.
We were using a regular expression to scan `/proc/<pid>/maps`, but we shouldn't really do that because it breaks non-bootstrapped builds. rdar://110452324
al45tair
force-pushed
the
eng/PR-110452324
branch
from
466e733 to
d396656
Compare
|
@swift-ci Please smoke test |
+1 on that. There is a reason I wanted to use a regex here. I suspect the state machine is faster, but probably not by nearly enough to justify the extra time to write it. |
What? You mean someone doesn't know what ASCII 9 is? :-D I sometimes forget I grew up in a world of 8-bit micros and dot matrix printers, so ended up just knowing lots of ASCII control codes. |
3 participants
We were using a regular expression to scan
/proc/<pid>/maps, but we shouldn't really do that because it breaks non-bootstrapped builds.rdar://110452324
Resolves #66457